Repository navigation
spec(FIX-1792): MAILBOX.md becomes WORKER.md on the coordinator flow, and the mailbox is removed - #2833
Conversation
… and old files are refused by name The retained spec set: one way to declare a coordinator, the per-board table (14 conversation boards, the DevTeam's feature as a workstream), old mailbox data left unread, and a four-PR plan over FIX-1791, FIX-1793 and FIX-1794. poc/inventory re-derives the counts (33 files, 15 with boards, 16 boards) and classifies every file and goal the removal touches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (direction only)Read SPEC, DECISIONS, PLAN, BUSINESS-RULES. The direction holds: one declaration shape, refuse the old file loudly, no boot-time conversion, boards go to whoever owns them. The goal check has a control and asserts on the message a person reads, which is what makes it worth trusting. D1 and D2 reasoning is sound; I'd keep both as written. Counts cross-check (10 + 16 + 4 + 3 = 33 files across P1–P4). Findings above the line, most important first: 1. P4 is the weak point of the PR plan. It bundles the loader refusal (S1–S3), the ~11,500-line / 32-file mailbox-floor removal (S9), the rest of the Shift Manager app (S8), the goal check and goal rewrites (S11), and docs (S12). A reviewer can't hold "did we delete the right things" and "does the refusal read well" in one diff, and the goal check (VG) is the proof for both. Suggest splitting: P4a = refusal + codegen refusal + pre-rename re-point (S1–S3) with the goal check, which can pass as soon as P1–P3 land; P4b = pure removal (S9, S10 leftovers, S8 remainder) gated by 2. D1's kitchen-sink half rests on an unproven assumption about FIX-1794. 3. Leg d's "a store today's 4. Hardening on the BR-3 / BR-4 asymmetry. An empty 5. Retiring Architecture note (opportunistic, no extra scope): removing Not blocking: the Items 1–3 would change the PR plan or the check; 4–5 are small edits. Generated by Claude Code |
There was a problem hiding this comment.
Simplify review (spec FIX-1792)
This PR is spec-only (~1.5k lines under specs/issues/FIX-1792/, no production packages). I ran parallel read-only passes (quality / performance / reuse) and re-ran node specs/issues/FIX-1792/poc/inventory/check.mjs locally (PASS).
Did the approach go too far?
For the product change, no. The title reads like “rename + refuse,” but the retained spec correctly owns the mailbox-floor removal program: D1/D2, four stacked PRs, twelve surfaces, and goal-check legs a–e. That breadth comes from the epic (ER-6, FIX-1367 locks), not from accidental scope creep in this diff. The six linked documents + figures match how this repo does direction approval.
For the evidence script, partly. The kernel loader story is ~15 lines of pseudocode in PLAN; the ongoing complexity tax is check.mjs: ~524 lines with hand-maintained FILES / FILE_CLASS (~189 paths) / GOALS (~49 units). Totality is the right invariant (it already caught 16 boards vs “15 boards” and the two flow: digest exceptions — good ROI). The question is whether totality needs to live in one monolithic, full-tree read for the whole epic life, or can be tiered so P1–P3 only maintain deltas.
Cleaner approaches (non-blocking suggestions)
| Idea | Trade-off |
|---|---|
Align Part 2 with FIX-1793’s runner (specs/issues/FIX-1793/poc/removal-inventory/check.mjs: git grep for identifiers, classified path set) |
Less duplicate scan logic; shared overlap on mintFor, setWorkstreams, claims. Keep full-file read only for goal /mailbox/i prose and --after REMOVED_EXPORTS. |
Split ledger from runner (FIX-1575 / FIX-1611 pattern: ledger.mjs + thin check.mjs) |
Same behavior; easier PR-by-PR table edits during P1–P4. |
| Two-tier totality | Census + MAILBOX.md FILES/EXPECT stay in spec; defer or generate “unclassified” for the full repo until P4, or classify only paths touched per PR. Weakens “nothing slips” during P1–P3 unless CI still runs grep. |
| Split Linear issues (refuse/convert vs remove floor) | Smaller sign-off surface; rejected by current epic framing — only if product re-slices. |
I would not block spec merge on these; they are implementer ergonomics and cross-issue inventory hygiene.
Smells worth watching (not PR blockers)
- Dual maintenance with FIX-1793 on overlapping paths and identifiers (
FILE_CLASSrows taggedT · FIX-1793vs 1793’s ownEDITmap). classed[c[0]]bucketing — assumes disposition strings always start with a single letter (R,E, …); fragile if labels change.listFiles()includes untracked (ls-files --others) while sibling POCs often use tracked-only +git add --intent-to-addfor controls — document why, or align with 1793 for consistency.staleregistry keys are reported but do not fail — fine for ergonomics; easy to misread PASS as “registry still accurate.”- Perf — full-repo
readFileSyncper file is fine for a manual/occasional gate; if this lands in every PR CI, consider grep-first or caching (low priority today).
Verdict
No major concerns for direction approval. The retained spec is coherent, testable, and the POC already falsified hand counts. The main simplification fork is how totality is enforced (monolith vs 1793-shaped grep + split ledger), not whether D1/D2 belong in FIX-1792.
I am not requesting changes before merge; treat inline notes as optional tightening before implementation PRs stack, or as a small follow-up amend on this spec if you want less inventory drift during P1–P3.
Sent by Cursor Automation: Review For Best Approach
Architect · coherence with #2828 (FIX-1794):
|
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: decision On The specialist's reply to the post carries the escalation. The coordinator files the case on its own conversation's board with FIX-1794's FIX-1794 (#2828, approved) doesn't change, there's no second filing path, and #2831's D6 stays as it is. The user sees the same thing: an escalated post becomes an open case on that conversation's board. Fold this into D1, S6, BR-14 and V5 in the next round. Keep P2/P3 waiting on FIX-1794, and keep S1 (the refusal) ahead of S9 (the removal) within P4, as the architect says. Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55cb6c59dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- escalate: the specialist's answer carries the case; the help coordinator files it on its own conversation's board with FIX-1794's fileTask, no assignee (coordinator's decision, option 1). D1, S6, BR-14, V5. - The last PR splits: P4a refuses (S1-S3, goal check legs a-d, upgrade page), P4b removes (S9, S8 rest, goal table, docs) and adds no behaviour. - flows/mailboxes/ is refused at load too (BR-4a, S1, V1), with the BR-3/BR-4 asymmetry stated. - Leg d's old store is a checked-in fixture from a pinned commit. - The retiring goal retires only once its live legs have a passing home. - Converted coordinators are found by worker id under FIX-1788 S5a's key-set match (BR-7a); FIX-1794 linked as merged; epic D6 cited. - POC: --after covers the full removed-export list (derived and kept total in census mode) and exempts only the two pinned old files; control extended. PASS, CONTROL PASS, --after FAIL (172) on main. - Cursor's notes recorded verbatim in PLAN -> Notes from review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: fold Review round 1 is folded in f4d944e. Folded (above the bar)
POC re-run: census PASS, Noted, not folded: Cursor's 6 inline threads and the suggestions in its review body are recorded verbatim in PLAN → Notes from review. Open for the implementer: FIX-1791's answer action ignores fields it doesn't define. If the case can't reach a landing step in the conversation's own request, that is raised on FIX-1791 (PLAN → At implement time). Generated by Claude Code |
- Kitchen-sink's help coordinator runs routing: judgment with rounds: 1. When the post's round closes, the answers wake its turn once (FIX-1791 BR-24). That turn files the case named by an `Escalate:` line in a specialist's answer, using FIX-1794's fileTask with no assignee. The escalation rides the answer's text, because BR-27 ignores fields it doesn't define. The escalate tool goes. Cost: one coordinator turn per answered post. Folded into D1, S6, BR-14, V5, the D1 table row, the SPEC diff and the what-changes figure. FIX-1791 doesn't change. - Coordinators whose member filed when a post reached it get the same shape: manager-queue-lab, multi-seat-collab, the row goal, the DevTeam's EM. The rest need nothing. - Discovery's `mailboxes` domain leaves MANIFEST_DOMAINS and core's discover description (S9, BR-5a, BR-22). `--after` asserts it, and the control proves it. The inventory also matches the quoted domain name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
Re the fold summary: 0d21ff5 makes the help coordinator Generated by Claude Code |
Architect · coherence with FIX-1791's PR plan:
|
jhoffner
left a comment
There was a problem hiding this comment.
from: fsd-head-of-engineering / session: em-fix-1786 / kind: spec-review-r2
Spec review round 2 (final) · 0d21ff5 · ABOVE_BAR, one finding
Round-1 folds: all present.
escalatethrough the coordinator: D1's Locks in and table row (DECISIONS:28, :38), Decided, not asked (:116–128), S6 (PLAN:21), BR-14, V5 (PLAN:93), SPEC:74–87.- Judgment with
rounds: 1holds against FIX-1791 as merged. The first hand-off is round 0 (its PLAN sketch), and 0 < 1, so the closed round wakes the turn once (BR-24). Hand-offs from that turn are round 1, and BR-25 wakes nothing after them. - That turn can file. FIX-1794 SPEC:79 gives every coordinator the four filing tools, and S1's partition is the conversation's own. With four delegates, BR-6 gives the pending, unassigned row.
- P4a/P4b (PLAN:6–8, :36–37). BR-4a (S1, V1, leg a).
REMOVED_EXPORTSplus--after, andAFTER_FIXTURES(check.mjs:67, :159, PLAN:112). BR-5a andMANIFEST_DOMAINS(S9, check.mjs:622). - Members that filed: their coordinator files for them (DECISIONS:53–58, PLAN:161–166). The members don't become coordinators, and no listed step needs a delegate to file.
Above the bar: the DevTeam's feature lead has to be a coordinator that takes a delegated post, and merged FIX-1791 doesn't provide that. DECISIONS:56–57 puts the EM's filing on the feature workstream lead's woken judgment turn, so eng.feature must be on the coordinator flow. To lead a workstream, it becomes a delegate record on the project coordinator (FIX-1793 S3, BR-21a). FIX-1791's S2 check, at add and at delivery, requires that record's flow to take a delegated post (BR-4). FIX-1791 S9 gives that entry to agent and to app flows that declare it, not to the coordinator flow. This spec's own PLAN:172–173 treats the same point as open for the chief of staff. As written, P3's openWorkstream can be refused, and D1's one workstream and the EM path have no conversation to run in.
Minimal fix: state the dependency in D1's Locks in and S7, and settle it now, as round 1 did for FIX-1794. Either confirm that FIX-1791's coordinator flow takes a delegated post and answers upward after its own round, or raise it on FIX-1791 through the epic (ER-24) and add that edge to P3.
For the implementer (notes, not folds):
- An
Escalate:line goes unfiled in two cases. One is an answer that lands after the round's deadline (FIX-1791 BR-24b). The other is an answer to a hand-off made in the woken turn (BR-25). Tell the coordinator not to hand off in that turn, and cover a late answer in V5 or on the upgrade page. - An unassigned filing triggers the board's run (FIX-1794 BR-10, BR-10a). Check that the run clears the pending-wake marker on a row nobody is assigned. Also check that the coordinator doesn't treat the filing's "assign it" reply as a failure.
- BR-7a:
findWorkerSession({ worker })returns the user's most recent conversation, so a panel should read the conversation it is showing. A workstream session carriesworkstreamId, so{ worker: eng.feature }never finds it (S5a). - "Waits for FIX-1802; it does not leave the goal" (PLAN:165) conflicts with VG on P4b, which needs a PASS line for every CONVERT and REWRITE goal. If a leg does wait, record it under BR-24 rather than adding an unstated FIX-1802 dependency to P4b.
Checks: validate-spec-folder.mjs passes. The census passes (33 · 15 · 16 · 3 · 0 · 2). --control catches 6 of 6 plants. --after fails on main with 173 problems, which is the expected red state.
Generated by Claude Code
- The DevTeam's feature board is now a conversation board on its coordinator, eng.feature, under judgment with rounds 1. Leading a workstream needs a coordinator that takes a delegated post. Merged FIX-1791 doesn't give the coordinator flow that (S9, BR-4), and multi-level delegation is deferred with the split to FIX-1802. All 15 boards are conversation boards. ops.release is a coordinator with no board. Storefront opens no workstream. Updated: D1 (heading, table, Locks in, figure, If wrong), S7, BR-15 to BR-17, the goal table, and the checker. The workstream conversion is now a follow-up with FIX-1802. - P1 to P3 depend on FIX-1791's P2, where everyone and rounds ship. P3 still needs FIX-1793, but only for S10. Rounds must not be cut from FIX-1791 P2. - No converted step waits on FIX-1802. it-codes-in-the-projects- repository retires under BR-24 with its proof named. - Round-2 notes 1 to 3 recorded verbatim in PLAN -> Notes from review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
Re round 2 and the architect's note: 112f5e6 makes all 15 boards conversation boards and moves the DevTeam's workstream conversion to FIX-1802 (follow-up). P1–P3 now wait on FIX-1791's P2, and Generated by Claude Code |
FIX-1792's spec (#2833, 112f5e6) keeps all 15 boards on conversations and moves the DevTeam's workstreams to FIX-1802. - D5 locks in: FIX-1792 waits on FIX-1793 only for the claims removal (S10). - PLAN step 4 and the FIX-1792 row carry #2833's per-PR dependencies: P1 after FIX-1791 through its P2 (everyone); P2 after FIX-1791 P2 (rounds) and FIX-1794; P3 after FIX-1791 P2, FIX-1794 and FIX-1793 (S10); P4a after P1-P3; P4b after P4a. - SPEC graph: the FIX-1793 to FIX-1792 edge is the claims to remove. - PLAN, not children: FIX-1802 carries the DevTeam's feature and release workstreams and their project placement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
Architect · 112f5e6: the FIX-1791 P2 ask is folded; the DevTeam deferral contradicts the epicMy ask is folded correctly. P1 to P3 now wait on FIX-1791's P2, and At implement time says New fork: the DevTeam's workstream moved to FIX-1802, but the claims are still removed here. Round 2 offered two fixes: confirm the coordinator flow takes a delegated post, or raise that on FIX-1791 through the epic (ER-24) and add the edge to P3. This commit takes a third path. As a result:
Ask: don't remove something until its replacement exists. Choose one, record it in D1, S10, BR-16 and BR-24, and get the choice onto the epic:
Everything else in 112f5e6 is consistent with what's merged: all 15 boards are conversation boards, and the coordinator files. |
- Filing is a tool any worker can be granted (FIX-1802). Members that filed today file themselves with FIX-1802's filing tools: the manager, the planner, the row filer and the DevTeam's EM. No coordinator files for a member, and nothing needs `rounds:`. - The DevTeam's feature and release are Storefront workstreams again, led by the EM. The EM is an ordinary worker that takes the project coordinator's delegated post (FIX-1791 S9) and files the coder's tasks. Claims are still removed in S10. The FIX-1793 dependency is restored, and it-codes-in-the-projects-repository converts again. - Kitchen-sink's escalation feature is removed, not replaced: support.help is back on best fit with its fallback; escalate.ts, its test, the no-filing control and the escalations board go; lists-a-filed-case retires (BR-24); two talk goals are rewritten. - D1 becomes 13 session boards and 1 workstream, with the escalations board removed. S5-S7, BR-13a/14-17/24, V5/V6, the sequence table (P2/P3 need FIX-1802; kitchen-sink moves to P1), DECISIONS, the history line, EVOLUTION, DOCS, the figures and the checker are all updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
Architect · coherence with #2839 (FIX-1802): does a coordinator need the filing grant?The two specs give opposite answers, and both are open.
If both merge as written, every coordinator this spec converts that files (kitchen-sink's Ask (conditional on #2839 D1 being approved as written):
If D1 on #2839 changes in review (for example, coordinators keep filing by flow), this spec stays as it is, and #2839 updates instead. Either way, it should be one answer in both specs before either merges. |
Every worker that files, coordinators included, is granted with `filing: true` and files through createTaskFilingCapability(); an app flow such as the EM's puts the capability on its generator block's uses and spreads the entries into its internal and task maps. A coordinator converted with no board gets no grant. Members list who they file for in `delegates:`. FIX-1802's pinned names replace the hedges, with one at-implement-time fallback. D1 moves to decided, not asked (the product owner removed the escalation feature, 2026-10-06), so D2 is the one sign-off item; the d1 anchor and the table stay. The round-2 Escalate: note is marked superseded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: fold The architect's coherence ask (FIX-1802's D1: every filer is granted, coordinators included) is folded in 2617d4b:
Census: PASS. Generated by Claude Code |
Architect · 2617d4b: the filing-grant ask is folded; no open forkChecked against my ask and #2839's D1:
Nothing more from the coherence side. If #2839's D1 changes in review, this spec follows it. |
…s spread FIX-1802's createTaskFilingCapability() returns entries the flow spreads into its actions, internal and task maps (actions carries fileTask and the other filing actions). Name actions wherever the spec describes that spread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
D2 approved and widened: no backwards support of any kind while there are no consumers. The MAILBOX.md, boards:, workstreams and mailboxes- domain refusals, the upgrade page, the pinned old store and the dual-reads go; old files are deleted in the conversion and old data is dropped. P4a collapses into the removal (P4), and the pre-rename refusal goes by the same rule. BP-030 recorded as not applying. No filing: key: a worker has orchestration's eight task tools (createTaskToolsCapability(resolver, roster), taskToolActions(board)) when one of its delegates can take a task. The census is re-run and its targets updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: sign-off-fold Folded the product owner's sign-off answers (2026-10-07) in 1 · D2 approved and widened: no backwards support while there are no consumers.
2 · No 3 · The tools are orchestration's existing ones. Checks: For the epic, not this PR: ER-6's third clause (refuse Generated by Claude Code |
Architect · 9f14e23: one drift against #2839's T1,
|
…er, roster) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: fold Folded in 2891222:
Generated by Claude Code |
Architect · 2891222: the
|
…ifth mechanism change D8 records T1 from FIX-1794's amended PLAN (#2839): createTaskToolsCapability's roster may be read per call, and taskToolActions(<board id>, resolver, roster) takes one too, so an app's addTask is checked against the session's current delegates. Generic orchestration change; names no worker or delegate. #2839 carries FIX-1794's D8 amendment, so the D9 sweep leaves FIX-1794 alone. D3, D1, ER-22, SPEC, PLAN and the d1-the-set and end-state figures now count five mechanism changes and one public rename. PLAN mirrors FIX-1792's four-PR plan on #2833 (P4 · remove, no refusal PR). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV


WORKER.mdfor each worker and aMAILBOX.mdfor each place where the workers talk. There are two formats and two loadersWORKER.mdfor both. A coordinator is a worker withflow: coordinatorand a list ofdelegates:delegates:can take a task. No line in its file grants themMAILBOX.md, or mailbox data in a storeGoal: each coordinator in the repo is declared in a
WORKER.mdon the coordinator flow, and it names only standard workers as delegates. No board is an org row, and no project finds its work through a claim. NoMAILBOX.mdand no mailbox code is left. Each goal and kitchen-sink check that ran on a mailbox passes on the converted files, unless the feature that it tested was removed.The check reads what the converted coordinator answers and what the tree still holds. Under the control, an old file and a removed export stay in the tree, and leg b must fail. Check:
goals/coordinators/every-coordinator-is-a-worker-file/, scripted model, controlGOAL_CONTROL=mailbox-left. Why this goal and not a smaller one: SPEC.md.One folder and one file format. The board moves from the org to the session of one user or to a workstream, and the old file is deleted with the code that read it.
How: each file is converted, line by line, and its
MAILBOX.mddeleted. Each board goes to a session board (FIX-1794) or, for the feature of the DevTeam, to a Storefront workstream (FIX-1793). A worker has the task tools when at least one of itsdelegates:can take a task: orchestration's existingcreateTaskToolsCapability(resolver, roster), with the session's board as the resolver and the delegates that take tasks as the roster, andtaskToolActions(<board id>, resolver, roster)for an app's actions (T1, FIX-1794 amended by #2839, adds the per-call roster). There is nofiling:key. The EM'semflow composes the capability on its generator block and spreads the actions. Kitchen-sink's escalation feature is removed, with its board. A last PR removes the mailbox code, the codegen slot and the pre-rename refusal. This issue uses parts that FIX-1791, FIX-1793, FIX-1794 and FIX-1802 add, and adds none of them. Four PRs.Answered
D2 · Old mailbox data is dropped; no consumers yet
The product owner approved D2 (2026-10-07) and widened it: no backwards support of any kind while there are no consumers. What that cut:
MAILBOX.md, aflows/mailboxes/folder, theboards:key, aworkstreamswrite, themailboxesdiscovery domain. Old files are deleted in the conversion instead.CHANNEL.mdrefusal. It is the same kind of support, and kept it would point atMAILBOX.md, a file that no longer exists. I decided this by the same rule. If you meant D2's rule to stop at mailboxes, it comes back as a re-pointed refusal.BP-030 does not apply while there are no consumers. DECISIONS records this as an epic decision.
Decided, not asked: D1, where each board goes. 11 session boards and 1 Storefront workstream that the EM leads. Kitchen-sink's escalations board goes with its feature. manager-queue-lab's two board-in-a-seat-folder trees go with the leg that they served, because no file declares a board now. The table.
One effect of the task-tools rule to know about: the rule reads delegates, not the old file. So each converted coordinator whose delegates are
agentworkers has the task tools, with or without a board. That includes kitchen-sink's help desk, though nothing asks it to file.Open: none. The reasons and what lost: DECISIONS.md. The cases: BUSINESS-RULES.md.
The PR plan
everyone)P4a ("refuse") is folded into the removal, because nothing has to be refused first. P4 adds no behaviour.
check.mjs --after, the goal check and the goal table judge it.Reviewers · look here
Not here: the word "mailbox" in names that this issue does not remove (FIX-1796), channels, and files as migrations. The epic's ER-6 and its docs already match D2 (D9 on #2837).
Spec · Decisions · Rules · Plan · Docs · Evolution · Linear FIX-1792 · epic FIX-1786 · builds on FIX-1791, FIX-1793, FIX-1794, FIX-1802 · merges after human approval and required checks (the contract)
POC — the checker that the counts rest on
node specs/issues/FIX-1792/poc/inventory/check.mjsre-derives the counts (33 files, 15 with boards, 16 boards, 3boardActions:, 0mintFor:, 2flow:). It classifies 197 files, 49 goal units and every removed export (107, including the pre-rename module's).--controlmust printCONTROL PASS.--afteris the end-state check for the implementation: it refuses each removed export and eachMAILBOX.md, with no exemptions. It fails onmaintoday (209 problems), as it must. It is evidence, not production code. README.How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.BUSINESS-RULES.mdmisses, or a rule that would invalidate the design.DOCS.mdand their fit with the rules; a missing ormisleading lineage claim in conditional
EVOLUTION.md.Out of scope — deliberately unsettled here, and owned by the implementing agent:
PLAN.mdpins on purpose.PLAN.mdleft open on purpose — it is directional by design, and a gap at thataltitude is intended, not an omission.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
PLAN.mdmay include a rough pseudocode sketchshowing the shape of the proposed solution. It is knowingly incomplete, is not real code,
and is not what will ship. Review it for directional viability only. Do not report
that it lacks error handling, omits edge cases, names things that don't exist in the repo, or
wouldn't build: all of that is true on purpose.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
PLAN.md → Notes from reviewfor the implementer to weigh against real code. It will not be argued with, and itwill not be folded into the design prose. Please don't re-raise it: one mention is enough.
The one exception is the sketch and the POC. Line-level feedback on either is dropped, not
recorded — there is nothing for an implementer to weigh about code that isn't shipping. Feedback
about their direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV